Re: [PATCH] Fix bugs in test script silent5.test.

[Stefano Lattarini]

At Wednesday 23 June 2010, Stefano Lattarini wrote:
> This tiny patch fix a nasty bug in 'silent5.test' (due to the use
> of grep instead of egrep) that could have lead to false negatives.
> ...
> -  grep '(CC|CXX|FC|F77|LD) ' stdout && Exit 1
> +  $GREP '(CC|CXX|FC|F77|LD) ' stdout && Exit 1
Ouch!  Stupid typo here (it should be $EGREP, not $GREP).  I'd truly 
like to have the `nounset' shell option enabled in the Automake 
testsuite...

Anyway, attached is a patch fixing the typo.

Sorry for the mistake,
   Stefano

From 05a66ba1d5c05ab64d575daa41d719cf41bc2593 Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Sat, 26 Jun 2010 14:12:07 +0200
Subject: [PATCH] Fix typo-related bug in test script silent5.test.

* tests/silent5.test: Use $EGREP, not $GREP (which is not even
defined).
---
 ChangeLog          |    6 ++++++
 tests/silent5.test |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 863d271..086e631 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-06-26  Stefano Lattarini  <address@hidden>
+
+       Fix typo-related bug in test script silent5.test.
+       * tests/silent5.test: Use $EGREP, not $GREP (which is not even
+       defined).
+
 2010-06-24  Stefano Lattarini  <address@hidden>
 
        Fix bugs in test script silent5.test.
diff --git a/tests/silent5.test b/tests/silent5.test
index 4a9c4c1..e29f48f 100755
--- a/tests/silent5.test
+++ b/tests/silent5.test
@@ -80,7 +80,7 @@ do_and_check_verbose_build ()
   grep ' -c ' stdout
   grep ' -o ' stdout
 
-  $GREP '(CC|CXX|FC|F77|LD) ' stdout && Exit 1
+  $EGREP '(CC|CXX|FC|F77|LD) ' stdout && Exit 1
 
   if $rebuild; then :; else
     grep 'ylwrap ' stdout
-- 
1.6.5