[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {master} Extend and improve tests on DejaGnu support.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] {master} Extend and improve tests on DejaGnu support. |
Date: |
Fri, 10 Dec 2010 18:56:16 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
Hi Stefano,
* Stefano Lattarini wrote on Fri, Dec 10, 2010 at 06:06:53PM CET:
> On Thursday 09 December 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sun, Nov 14, 2010 at 02:29:33PM CET:
> > > + $MAKE distcheck
> >
> > Can't you either omit this distcheck, or the vpath = : case above,
> > without decreasing coverage?
> >
> The "vpath = :" case also checks the reaction to failing tests in a
> VPATH build, so I'd rather not remove it. As for the distcheck, I
> think it has a real, albeit limited, usefulness, since it shows that
> the package is self-contained and its distribution works as expected.
> So I'd prefer to keep it, but I can also remove it if you insist.
>
> Hmm... but thinking about it, running "make distcheck" only once would
> IMHO be better in terms of performance, and wouldn't hinder coverage.
>
> So what about the following squash-in?
Looks better. OK to go with it!
Thanks!
Ralf