[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] {master} Extend and improve tests on DejaGnu support.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCH] {master} Extend and improve tests on DejaGnu support. |
Date: |
Sat, 11 Dec 2010 11:39:36 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Friday 10 December 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Fri, Dec 10, 2010 at 06:06:53PM CET:
> > On Thursday 09 December 2010, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Sun, Nov 14, 2010 at 02:29:33PM CET:
> > > > + $MAKE distcheck
> > >
> > > Can't you either omit this distcheck, or the vpath = : case above,
> > > without decreasing coverage?
> > >
> > The "vpath = :" case also checks the reaction to failing tests in a
> > VPATH build, so I'd rather not remove it. As for the distcheck, I
> > think it has a real, albeit limited, usefulness, since it shows that
> > the package is self-contained and its distribution works as expected.
> > So I'd prefer to keep it, but I can also remove it if you insist.
> >
> > Hmm... but thinking about it, running "make distcheck" only once would
> > IMHO be better in terms of performance, and wouldn't hinder coverage.
> >
> > So what about the following squash-in?
>
> Looks better. OK to go with it!
>
> Thanks!
> Ralf
>
Merged to master and pushed now.
Thanks,
Stefano