Re: too many warnings from Bison CVS for Pike

[Paul Eggert]

"Joel E. Denny" <address@hidden> writes:

> Is this the only case that causes problems?

No, the bro grammar also causes problems.  See
<http://bro-ids.org/download.html>.  I used bro-0.9a9, the
then-current stable release.  If you use the command "cvs co -D
'2006-01-22 23:59:41 -0800' bison" to check out the version of Bison
just before the changes, and apply it to bro-0.9a9/src/parse.y, you'll
get this output:

parse.y:326.17-339.25: warning: unused value: $6
parse.y:470.17-474.25: warning: unset value: $$
parse.y:495.17-499.25: warning: unset value: $$
parse.y:634.17-639.33: warning: unused value: $3
parse.y:655.17-661.33: warning: unused value: $3
parse.y:707.17-708.56: warning: unset value: $$
parse.y:717.17-718.43: warning: unset value: $$
parse.y:741.17-742.43: warning: unset value: $$
parse.y:743.17-744.43: warning: unset value: $$
parse.y:805.17-806.27: warning: unused value: $1
parse.y:805.17-806.27: warning: unused value: $2
parse.y:853.17-859.25: warning: unset value: $$
parse.y:863.17-864.61: warning: unused value: $3
parse.y:905.17-906.36: warning: unset value: $$
parse.y:905.17-906.36: warning: unused value: $3
parse.y:926.17-927.43: warning: unset value: $$
parse.y:1013.17-1014.57: warning: unset value: $$
parse.y:1081.17-1085.25: warning: unset value: $$
parse.y:1099.17-1100.43: warning: unset value: $$
parse.y:1145.17-1146.43: warning: unset value: $$
conflicts: 9 shift/reduce

This is much better than Pike's 196 warnings, but still, those
warnings are all of questionable utility.  By "questionable" I don't
mean that the warnings are wrong, just that some people might object
to them and they might get in the way.  If we enabled these warnings
via an option I don't think people would object.

Pike and bro were the only two "outside" grammars that I tested the
new Bison warnings on.  Granted, these two grammars are outliers to
some extent, since they were preventing freebsd ports from using Bison
2.1; but still, I suspect they're not all that atypical.

With the patch I installed on 2006-01-27, Bison issues only one
warning for bro's parse.y:

parse.y:905.17-906.36: warning: unused value: $3

This particular warning is worse than questionable: it's 100% bogus.
But it's caused by a separate and longstanding bug in Bison, having to
do with two adjacent actions.  I didn't know about that bug, but I'm
about to install a fix for it.


For the record, here are the diagnostics that 2006-01-22 23:59:41
-0800 bison generates for Pike 7.6.50 language.yacc
<http://pike.ida.liu.se/pub/pike/all/7.6.50/Pike-v7.6.50.tar.gz>.  All
but two of these diagnostics are questionable.  I've appended '[OK]'
to the non-questionable diagnostics.

language.yacc:444.14-458.3: warning: unused value: $2
language.yacc:459.5-464.3: warning: unused value: $1
language.yacc:459.5-464.3: warning: unused value: $2
language.yacc:465.5-471.3: warning: unused value: $1
language.yacc:465.5-471.3: warning: unused value: $2
language.yacc:472.5-477.3: warning: unused value: $1
language.yacc:472.5-477.3: warning: unused value: $2
language.yacc:478.5-48: warning: unused value: $1
language.yacc:478.5-48: warning: unused value: $2
language.yacc:479.5-483.3: warning: unused value: $1
language.yacc:479.5-483.3: warning: unused value: $2
language.yacc:484.5-64: warning: unused value: $1
language.yacc:484.5-64: warning: unused value: $2
language.yacc:563.11-53: warning: unused value: $1
language.yacc:564.5-49: warning: unused value: $1
language.yacc:565.5-569.3: warning: unused value: $1
language.yacc:570.5-65: warning: unused value: $1
language.yacc:918.5-923.3: warning: unused value: $1
language.yacc:918.5-923.3: warning: unused value: $3
language.yacc:924.5-931.3: warning: unused value: $1
language.yacc:924.5-931.3: warning: unused value: $3
language.yacc:924.5-931.3: warning: unused value: $7
language.yacc:932.5-44: warning: unused value: $1
language.yacc:1016.24-47: warning: unused value: $1
language.yacc:1017.5-29: warning: unused value: $2
language.yacc:1030.5-38: warning: unused value: $1
language.yacc:1032.5-38: warning: unused value: $1
language.yacc:1035.5-51: warning: unused value: $1
language.yacc:1036.5-38: warning: unused value: $1
language.yacc:1037.5-38: warning: unused value: $1
language.yacc:1038.5-41: warning: unused value: $1
language.yacc:1039.5-38: warning: unused value: $1
language.yacc:1044.5-37: warning: unused value: $1
language.yacc:1046.5-37: warning: unused value: $1
language.yacc:1048.5-38: warning: unused value: $1
language.yacc:1049.5-36: warning: unused value: $1
language.yacc:1050.5-37: warning: unused value: $1
language.yacc:1051.5-40: warning: unused value: $1
language.yacc:1052.5-37: warning: unused value: $1
language.yacc:1058.5-38: warning: unused value: $1
language.yacc:1059.5-39: warning: unused value: $1
language.yacc:1060.5-39: warning: unused value: $1
language.yacc:1061.5-41: warning: unused value: $1
language.yacc:1062.5-42: warning: unused value: $1
language.yacc:1063.5-40: warning: unused value: $1
language.yacc:1064.5-42: warning: unused value: $1
language.yacc:1065.5-41: warning: unused value: $1
language.yacc:1066.5-40: warning: unused value: $1
language.yacc:1067.5-39: warning: unused value: $1
language.yacc:1068.5-37: warning: unused value: $1
language.yacc:1074.5-33: warning: unused value: $1
language.yacc:1075.5-33: warning: unused value: $1
language.yacc:1076.5-34: warning: unused value: $1
language.yacc:1077.5-36: warning: unused value: $1
language.yacc:1078.5-35: warning: unused value: $1
language.yacc:1079.5-38: warning: unused value: $1
language.yacc:1080.5-36: warning: unused value: $1
language.yacc:1081.5-36: warning: unused value: $1
language.yacc:1083.5-36: warning: unused value: $1
language.yacc:1084.5-35: warning: unused value: $1
language.yacc:1086.5-39: warning: unused value: $1
language.yacc:1087.5-38: warning: unused value: $1
language.yacc:1089.5-38: warning: unused value: $1
language.yacc:1090.5-37: warning: unused value: $1
language.yacc:1091.5-37: warning: unused value: $1
language.yacc:1092.5-37: warning: unused value: $1
language.yacc:1093.5-37: warning: unused value: $1
language.yacc:1094.5-37: warning: unused value: $1
language.yacc:1226.5-61: warning: unused value: $1
language.yacc:1227.5-60: warning: unused value: $1
language.yacc:1228.5-61: warning: unused value: $1
language.yacc:1229.5-62: warning: unused value: $1
language.yacc:1230.5-40: warning: unused value: $1
language.yacc:1231.5-40: warning: unused value: $1
language.yacc:1232.5-40: warning: unused value: $1
language.yacc:1233.5-40: warning: unused value: $1
language.yacc:1234.5-63: warning: unused value: $1
language.yacc:1235.5-61: warning: unused value: $1
language.yacc:1236.5-64: warning: unused value: $1
language.yacc:1484.33-56: warning: unused value: $1
language.yacc:1485.5-50: warning: unused value: $1
language.yacc:1538.5-36: warning: unused value: $1
language.yacc:1564.5-1567.3: warning: unused value: $1
language.yacc:1568.5-1572.3: warning: unused value: $1
language.yacc:1573.5-1576.3: warning: unused value: $1
language.yacc:1595.5-43: warning: unused value: $1
language.yacc:1611.5-1615.3: warning: unused value: $1
language.yacc:1616.5-1621.3: warning: unused value: $1
language.yacc:1622.5-1628.3: warning: unused value: $1
language.yacc:1705.5-1706.72: warning: unused value: $3  [OK]
language.yacc:1710.5-1711.72: warning: unused value: $3  [OK]
language.yacc:1815.12-1818.3: warning: unset value: $$
language.yacc:1815.12-1818.3: warning: unused value: $1
language.yacc:1850.8-60: warning: unused value: $1
language.yacc:1851.10-55: warning: unused value: $1
language.yacc:1852.5-1855.3: warning: unused value: $1
language.yacc:1858.11-69: warning: unused value: $1
language.yacc:1866.9-1958.3: warning: unused value: $1
language.yacc:1959.5-1965.3: warning: unused value: $1
language.yacc:2091.5-2095.3: warning: unused value: $1
language.yacc:2229.5-2234.3: warning: unused value: $1
language.yacc:2237.13-2268.3: warning: unused value: $1
language.yacc:2269.5-67: warning: unused value: $1
language.yacc:2269.5-67: warning: unused value: $3
language.yacc:2272.20-41: warning: unused value: $1
language.yacc:2273.5-53: warning: unused value: $3
language.yacc:2274.5-2278.3: warning: unused value: $3
language.yacc:2281.31-54: warning: unused value: $1
language.yacc:2282.5-36: warning: unused value: $2
language.yacc:2292.5-2400.3: warning: unset value: $$
language.yacc:2411.8-2510.3: warning: unused value: $6
language.yacc:2584.7-2608.3: warning: unused value: $1
language.yacc:2611.10-2628.3: warning: unused value: $1
language.yacc:2631.7-2652.3: warning: unused value: $1
language.yacc:2665.5-33: warning: unused value: $1
language.yacc:2687.10-2713.3: warning: unused value: $1
language.yacc:2716.5-2723.3: warning: unused value: $1
language.yacc:2716.5-2723.3: warning: unused value: $4
language.yacc:2724.5-2730.3: warning: unused value: $1
language.yacc:2724.5-2730.3: warning: unused value: $3
language.yacc:2724.5-2730.3: warning: unused value: $4
language.yacc:2731.5-2737.3: warning: unused value: $1
language.yacc:2731.5-2737.3: warning: unused value: $3
language.yacc:2748.6-2768.3: warning: unused value: $1
language.yacc:2772.9-2790.3: warning: unused value: $1
language.yacc:2797.9-2814.3: warning: unused value: $1
language.yacc:2817.7-2820.3: warning: unused value: $1
language.yacc:2821.5-2824.3: warning: unused value: $1
language.yacc:2825.5-2828.3: warning: unused value: $1
language.yacc:2847.9-2858.3: warning: unused value: $1
language.yacc:2859.5-2862.3: warning: unused value: $1
language.yacc:2908.5-62: warning: unused value: $2
language.yacc:2909.5-42: warning: unused value: $2
language.yacc:2940.5-29: warning: unused value: $2
language.yacc:2949.5-31: warning: unused value: $2
language.yacc:3281.5-3345.3: warning: unused value: $1
language.yacc:3346.5-3349.3: warning: unused value: $1
language.yacc:3385.5-32: warning: unset value: $$
language.yacc:3385.5-32: warning: unused value: $1
language.yacc:3386.5-23: warning: unset value: $$
language.yacc:3386.5-23: warning: unused value: $1
language.yacc:3462.5-65: warning: unused value: $1
language.yacc:3491.5-3505.3: warning: unused value: $1
language.yacc:3506.5-3509.3: warning: unused value: $1
language.yacc:3560.5-46: warning: unused value: $1
language.yacc:3561.5-37: warning: unused value: $1
language.yacc:3619.8-3632.3: warning: unused value: $1
language.yacc:3680.8-3688.6: warning: unused value: $1
language.yacc:3691.9-3694.3: warning: unused value: $1
language.yacc:3695.5-3701.3: warning: unused value: $1
language.yacc:3702.5-3709.3: warning: unused value: $1
language.yacc:3710.5-3716.3: warning: unused value: $1
language.yacc:3717.5-3723.3: warning: unused value: $1
language.yacc:3724.5-3729.3: warning: unused value: $1
language.yacc:3730.5-3736.3: warning: unused value: $1
language.yacc:3737.5-3742.3: warning: unused value: $1
language.yacc:3743.5-3748.3: warning: unused value: $1
language.yacc:3749.5-47: warning: unused value: $1
language.yacc:3750.5-3754.3: warning: unused value: $1
language.yacc:3755.5-63: warning: unused value: $1
language.yacc:3756.5-63: warning: unused value: $1
language.yacc:3801.5-3802.43: warning: unused value: $1
language.yacc:3807.5-3808.42: warning: unused value: $1
language.yacc:3809.5-3810.45: warning: unused value: $1
language.yacc:3811.5-3812.41: warning: unused value: $1
language.yacc:3813.5-3814.45: warning: unused value: $1
language.yacc:3815.5-3816.43: warning: unused value: $1
language.yacc:3817.5-3818.46: warning: unused value: $1
language.yacc:3819.5-3820.44: warning: unused value: $1
language.yacc:3821.5-3822.45: warning: unused value: $1
language.yacc:3823.5-3824.44: warning: unused value: $1
language.yacc:3827.5-3828.42: warning: unused value: $1
language.yacc:3832.5-3833.44: warning: unused value: $1
language.yacc:3834.5-3835.43: warning: unused value: $1
language.yacc:3836.5-3837.44: warning: unused value: $1
language.yacc:3838.5-3839.44: warning: unused value: $1
language.yacc:3840.5-3841.45: warning: unused value: $1
language.yacc:3842.5-3843.47: warning: unused value: $1
language.yacc:3844.5-3845.44: warning: unused value: $1
language.yacc:3850.5-3851.44: warning: unused value: $1
language.yacc:3856.5-3857.40: warning: unused value: $1
language.yacc:3858.5-3859.34: warning: unused value: $1
language.yacc:3860.5-3861.44: warning: unused value: $1
language.yacc:3864.5-3865.45: warning: unused value: $1
language.yacc:3866.5-3867.43: warning: unused value: $1
language.yacc:3868.5-3869.43: warning: unused value: $1
language.yacc:3870.5-3871.44: warning: unused value: $1
language.yacc:3872.5-3873.44: warning: unused value: $1
language.yacc:3874.5-3875.44: warning: unused value: $1
language.yacc:3878.5-3879.43: warning: unused value: $1
language.yacc:3880.5-3881.42: warning: unused value: $1
language.yacc:3882.5-3883.46: warning: unused value: $1
language.yacc:3884.5-3885.45: warning: unused value: $1
language.yacc:3886.5-3887.41: warning: unused value: $1
language.yacc:3888.5-3889.45: warning: unused value: $1
language.yacc:3890.5-3891.40: warning: unused value: $1