Re: [bongo-patches] Audio CD fixes

[Daniel Brockman]

address@hidden (Daniel Jensen) writes:

> So I finally got around to testing the CDDA code a little.

Awesome.  My testing so far has been really poor.
I think I've tried it with like one CD total.

> Notes:
>
>   * `bongo-libcddb-cdda-info' must not give track lengths by calling
>     `bongo-libcddb-cddb-info'. This ignores `bongo-use-cddb' and is
>     probably a bad idea anyway.

Okay, you're probably right.

>   * `bongo-libcddb-cdda-info' checks for an ID that the `cddb_query
>     calc' command only will find for valid CDs, to prevent 255
>     inserted tracks when no CD is in the tray. Daniel, you removed
>     this earlier for some reason.

Sorry, I didn't mean to.

>   * `bongo-cdtool-cdda-info' detects a data CD, to prevent another
>     unwanted track insertion.
>
>   * `bongo-cdtool-cddb-info' handles multiple matches from the server
>     by always selecting a first match.

Good, and good. :-)

> Plus other minor changes.

Thanks a lot.  I did some minor nitpicking below.

> diff -Naur old-bongo/bongo.el new-bongo/bongo.el
> --- old-bongo/bongo.el        2007-01-04 06:46:43.000000000 +0100
> +++ new-bongo/bongo.el        2007-01-04 06:56:33.000000000 +0100
> @@ -4693,20 +4693,18 @@
>  
>  (defun bongo-libcddb-cdda-info (&optional device omit-lengths)
>    "Use `cddb_query' to find the number of tracks on an audio CD.
> +Track lengths are not retrieved. OMIT-LENGTHS is ignored.

In the future, please use two spaces after sentences.
This is standard in GNU code and lets you use M-a and M-e.

[...]

> @@ -4799,7 +4800,7 @@
>  Return a CD device name or nil."
>    (let ((file-name
>           (read-file-name (format "CD device name (default `%s'): "
> -                                 bongo-cd-device)
> +                                 (or bongo-cd-device "unspecified"))

I changed this to the following,

                         (format "CD device name (default %s): "
                                 (if bongo-cd-device
                                     (format "`%s'" bongo-cd-device)
                                   "unspecified"))

so as to avoid suggesting that "unspecified" is some sort of
special value.


Thanks again,

-- 
Daniel Brockman <address@hidden>