bug-cfengine
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

AppendIfNoSuchLine in 2.0.6


From: Chip Seraphine
Subject: AppendIfNoSuchLine in 2.0.6
Date: Mon, 21 Apr 2003 14:19:50 -0500
User-agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.2.1) Gecko/20030121


I've run a lot more tests, and am finding that the AppendIfNoSuchLine function is definitely causing problems with 2.0.6 that do not happen in 2.0.5. Specifically, it appends the raw pattern to be matched instead of the previous SetLine value.

A diff of editfiles.c between 2.0.6 (<) and 2.0.5 (>) shows this:

552c530
<                   AppendItem(&filestart,expdata,NULL);
---
>                   AppendItem(&filestart,EDITBUFF,NULL);

I'm not overly familiar with the cfengine code, but this surely seems to be a deliberate change-- the edit buffer was replaced with the expression data, which is exactly what I am seeing in my files.

Does anybody know why this was done?  Is it safe to roll back this change?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]