bug-cfengine
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AppendIfNoSuchLine in 2.0.6


From: Chip Seraphine
Subject: Re: AppendIfNoSuchLine in 2.0.6
Date: Mon, 21 Apr 2003 14:34:10 -0500
User-agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.2.1) Gecko/20030121

Whoops, now I see what you mean. I indeed meant to say "AppendIfNoLineMatching". I have the old AppendIfNoSuchLine on my brain since I have been frantically converting my conf files to use it instead :-)

To clarify: "AppendIfNoLineMatching" is appending the expression instead of the previous SetLine value, presumably as a result of the diff below.

address@hidden wrote:

On 21 Apr, Chip Seraphine wrote:
I've run a lot more tests, and am finding that the AppendIfNoSuchLine function is definitely causing problems with 2.0.6 that do not happen in 2.0.5. Specifically, it appends the raw pattern to be matched instead of the previous SetLine value.

A diff of editfiles.c between 2.0.6 (<) and 2.0.5 (>) shows this:

552c530
<                   AppendItem(&filestart,expdata,NULL);
---
>                   AppendItem(&filestart,EDITBUFF,NULL);


Needless to say, this should be EDITBUFF on the line mentioned here,
as you indicate. Possibly this is a cut'n'paste error from a tweak.
However, the code for AppendIfNoSuchLine seems correct.

M

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272            Email:  address@hidden
Fax : +47 22453205            WWW  :  http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~








reply via email to

[Prev in Thread] Current Thread [Next in Thread]