bug-cpio
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-cpio] [PATCH] lib/paxnames.c: Do not use alloca to avoid stack


From: Sergey Poznyakoff
Subject: Re: [Bug-cpio] [PATCH] lib/paxnames.c: Do not use alloca to avoid stack overflow
Date: Fri, 17 Aug 2007 14:05:28 +0300

Dmitry V. Levin <address@hidden> ha escrit:

> My suggestion is to avoid using alloca() with user controllable size.
> In this particular case, memcpy() call could be optimized out as well.

The proposed patch will make things worse: tar will segfault, because
the passed string is freed after inserting it in the hash table.

Regards,
Sergey




reply via email to

[Prev in Thread] Current Thread [Next in Thread]