Re: [Bug-cpio] [PATCH] lib/paxnames.c: Do not use alloca to avoid stack overflow

[Dmitry V. Levin]

On Thu, Aug 23, 2007 at 02:44:10PM +0200, Ladislav Michnovi?? wrote:
> 2007/8/23, Dmitry V. Levin <address@hidden>:
> > On Tue, Aug 21, 2007 at 02:11:12PM +0200, Ladislav Michnovic wrote:
> > >It was not used before cpio version 2.7. Am I right?
> >
> > The safer_name_suffix() function is part of paxlib (code shared between
> > GNU cpio and GNU tar); was introduced approx. in tar-1.13.26 and later
> > used in cpio-2.7 via paxlib.
> 
> Thank you for clarification. As I go through patches, I think your
> patch https://savannah.gnu.org/patch/?4005
> uses alloca. So may be affected too.

As of cpio-2.9, that patch is mostly obsolete.
I still think that no_abs_paths_flag should be set by default to "true" in
extract mode, see
http://git.altlinux.org/people/ldv/packages/?p=cpio.git;a=commitdiff;h=2.6-alt17-20-gf184c20
or
http://cvsweb.openwall.com/cgi/cvsweb.cgi/~checkout~/Owl/packages/cpio/cpio-2.9-alt-no_abs_paths_flag.diff?rev=1.1;content-type=text%2Fplain


-- 
ldv

pgpyeT9DA1zUT.pgp
Description: PGP signature