bug-gawk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] [PATCH] Fix typos in comments.


From: Yi, EungJun
Subject: Re: [bug-gawk] [PATCH] Fix typos in comments.
Date: Wed, 9 May 2012 03:12:16 +0900

Originally I submitted this patch in Git mailing list, and Zbyszek
suggested to change past tense to present tense as follows.
I also agree on it.

"If an error occurs, ERR is set to the error code, and NULL is returned."

(See http://marc.info/?l=git&m=133631699226474&w=2)

While I am reading the comments, the errata make me a little bit
nervous, but they don't cause misunderstanding.
So if you feel it's better that leave them as they are, do as you please.

p.s. The Git developers have made some changes to gawk included in Git.
They would be happy if you consider to pull the changes.

(See http://marc.info/?l=git&m=133630910724321&w=2)

2012/5/7 Derek Fawcus <address@hidden>:
> On Sun, May 06, 2012 at 10:38:48pm +0900, Yi, EungJun wrote:
>> From: "Yi, EungJun" <address@hidden>
>>
>> occured => occurred
>
> If one is going to do that,  then the grammer should also be fixed.
>
> i.e. 'is occurred' should be either 'has occurred' or simply 'occurred', 
> except for the last instance.
> That should either be 'will occur',  or I also changed to past tense
> ('if an error occurred'/'if an error has occurred') so as to match the form 
> of the others.
>
> But is such deemed worthwhile?  (I simply ask,  I'm not implying it isn't).
>
> .pdf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]