bug-gawk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gawk] [PATCH 2/2] Fix plugin load failure on OS/2


From: KO Myung-Hun
Subject: Re: [bug-gawk] [PATCH 2/2] Fix plugin load failure on OS/2
Date: Fri, 13 Oct 2017 11:10:28 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2

Hi/2.

address@hidden wrote:
> Hi All.
> 
> Thanks KO & Eli for working this out.
> 
> Eli Zaretskii <address@hidden> wrote:
> 
>> Thanks.  Let's see if there are objections, and if not, I will push it
>> in a few days in your name.
> 
> Minor nit:
> 
>> +    char sym[strlen(name) + 1 + 1]; /* 1 for '-', 1 for NUL */
> 
> Should be     /* 1 for '_', 1 for NUL */
> 
> Please fix in both places.
> 
> Otherwise looks good to me.
> 
> I will work on the fork issue Andreas mentioned.
> 
> Thanks!
> 
> Arnold

Fixed.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/

Attachment: v2-0001-Fix-dlsym-failures-on-OS-2-kLIBC.patch
Description: Source code patch

Attachment: v2-0002-Fix-plugin-load-failure-on-OS-2.patch
Description: Source code patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]