[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Removing messages which confuse the user (Re: [PATCH] Function palye
From: |
Hideki IWAMOTO |
Subject: |
Re: Removing messages which confuse the user (Re: [PATCH] Function palyer plugin parser) |
Date: |
Fri, 19 Feb 2010 21:01:45 +0900 |
Hi.
On Fri, 19 Feb 2010 09:40:15 +0900, Shigio YAMAGUCHI wrote...
> > > 2. How about not making empty GRTAGS and GSYMS?
> >
> > There is a case where this causes a problem.
>
> I made a patch to remove some messages which might confuse the user.
>
You are right. This message should not be output when there is no tag to add.
Please make same change in updatetags_using_builtin_parser(), and commit to the
repository.
> *** gtags.c- Fri Feb 19 09:21:09 2010
> --- gtags.c Fri Feb 19 09:16:49 2010
> ***************
> *** 1207,1213 ****
> if (vflag)
> fprintf(stderr, "[%s] Creating '%s' and '%s'.\n", now(),
> dbname(GRTAGS), dbname(GSYMS));
> data.gtop[GSYMS] = gtags_open(dbpath, root, GSYMS, GTAGS_CREATE,
> openflags);
> ! if (vflag) {
> if (file_list)
> find_open_filelist(file_list, root);
> else
> --- 1207,1213 ----
> if (vflag)
> fprintf(stderr, "[%s] Creating '%s' and '%s'.\n", now(),
> dbname(GRTAGS), dbname(GSYMS));
> data.gtop[GSYMS] = gtags_open(dbpath, root, GSYMS, GTAGS_CREATE,
> openflags);
> ! if (ftell(tmp) > 0 && vflag) {
> if (file_list)
> find_open_filelist(file_list, root);
> else
> --
> Shigio YAMAGUCHI <address@hidden>
> PGP fingerprint: D1CB 0B89 B346 4AB6 5663 C4B6 3CA5 BBB3 57BE DDA3
----
Hideki IWAMOTO address@hidden
- Re: [PATCH] Function palyer plugin parser, (continued)
- Re: [PATCH] Function palyer plugin parser, Shigio YAMAGUCHI, 2010/02/17
- Re: [PATCH] Function palyer plugin parser, Hideki IWAMOTO, 2010/02/17
- Re: [PATCH] Function palyer plugin parser, Shigio YAMAGUCHI, 2010/02/17
- Re: [PATCH] Function palyer plugin parser, Hideki IWAMOTO, 2010/02/17
- New rule (Re: [PATCH] Function palyer plugin parser), Shigio YAMAGUCHI, 2010/02/17
- Re: New rule (Re: [PATCH] Function palyer plugin parser), Hideki IWAMOTO, 2010/02/20
- Re: New rule (Re: [PATCH] Function palyer plugin parser), Shigio YAMAGUCHI, 2010/02/20
- Re: New rule (Re: [PATCH] Function palyer plugin parser), Hideki IWAMOTO, 2010/02/25
- Re: New rule (Re: [PATCH] Function palyer plugin parser), Shigio YAMAGUCHI, 2010/02/25
- Removing messages which confuse the user (Re: [PATCH] Function palyer plugin parser), Shigio YAMAGUCHI, 2010/02/18
- Re: Removing messages which confuse the user (Re: [PATCH] Function palyer plugin parser),
Hideki IWAMOTO <=
- Re: Removing messages which confuse the user (Re: [PATCH] Function palyer plugin parser), Shigio YAMAGUCHI, 2010/02/19
- Re: Removing messages which confuse the user (Re: [PATCH] Function palyer plugin parser), Hideki IWAMOTO, 2010/02/19
- Re: Removing messages which confuse the user (Re: [PATCH] Function palyer plugin parser), Shigio YAMAGUCHI, 2010/02/20
- Re: [PATCH] Function palyer plugin parser, Hideki IWAMOTO, 2010/02/17
- Re: [PATCH] Function palyer plugin parser, Shigio YAMAGUCHI, 2010/02/17
- Re: [PATCH] Function palyer plugin parser, Hideki IWAMOTO, 2010/02/18
- Re: [PATCH] Function palyer plugin parser, Hideki IWAMOTO, 2010/02/18
- Re: [PATCH] Function palyer plugin parser, Shigio YAMAGUCHI, 2010/02/18