[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#29799: 24.5; cl-loop guard clause missing
From: |
Tino Calancha |
Subject: |
bug#29799: 24.5; cl-loop guard clause missing |
Date: |
Mon, 08 Jan 2018 19:20:35 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> Tino Calancha <tino.calancha@gmail.com> writes:
>
>> Fix #Bug#29799
>>
>> * lisp/emacs-lisp/cl-macs.el (cl--loop-guard-cond): New variable.
>> (cl--parse-loop-clause): Set it non-nil if the loop contains
>> a for/as clause.
>> (cl-loop): After update the loop variable, update other variables
>> only if cl--loop-guard-cond is non-nil.
>>
>> * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs-loop-for-as-equals-and):
>> New test.
>
> Looks good, but please add some more info to the summary line.
Thank you very much.
Extended the commit message with more detailed explanations.
Fixed in master branch as commit 'cl-loop: Add missing guard condition'
(a0365437c9ee308ad7978e436631020f513b25e7).