Re: [Bug-gnubg] New: Setting language within gnubg

[Jim Segrave]

On Wed 27 Aug 2003 (16:10 +0200), Jim Segrave wrote:
> On Wed 27 Aug 2003 (14:35 +0200), Nardy Pillards wrote:
> > > The GUI option is located under Settings|Options|Other. In the CLI the
> > > command "set lang de_DE" sets gnubg to German. "set lang system" is
> > > for people that want to use the system's setting, specified by the
> > > LANG environment variable or on Windows what's set in the OS
> > > preferences. It's also the default. "show lang" shows the current
> > > setting.
> > > 
> > > I've left the command line option of Jim in. This takes precedence
> > > over all other settings.
> 
> I've put in a couple of fixes.
> 
> char *szLang="system"; can put the string "system" in read-only
>   memory. It could also be overwritten with longer strings. I don't
>   think this was the problem

This is slightly wrong - the original was char szLang[]= "system";
which would not be a candiate for read only memory (but isn't big
enough for what CommandSetLang() does. 
 
> putenv(char *envstring) under glibc puts the actual pointer envstring
> into the environment, so it can not be a local variable. Under FreeBSD
> and Solaris, a copy of envstring is put in the environment, under
> Linux the environment variable disappears and is replaced with junk.
> 
> I don't know if this is the cause, but I've committed a fix.

-- 
Jim Segrave           address@hidden