bug-gnulib
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: crc

From: Simon Josefsson
Subject: Re: crc
Date: Sat, 08 Oct 2005 10:12:31 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) 
Bruno Haible <address@hidden> writes:

> Simon Josefsson wrote:
>> Ok to install?
>
>> +/* Compute CRC-32 value of LEN bytes long BUF, and return it. */
>> +extern unsigned long crc32 (char *buf, size_t len);
>> ...
>
> All 4 functions don't write into buf, therefore the 'buf' argument type should
> be 'const char *', not 'char *'.

Fixed.

>> +   Due to historic implementatio errrs, this variant is sometimes used
>> ...
>> +   initial and final XOR operation.  Due to historic implementatio
>> +   errrs, this variant is sometimes used (i.e., in RFC 3961).  */
>
> 4 typos in comments.

Lossy wireless keyboards...

Thanks,
Simon
reply via email to
[Prev in Thread] Current Thread [Next in Thread]