[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Yet another sha1/md[45] refinement
|
From: |
Simon Josefsson |
|
Subject: |
Re: Yet another sha1/md[45] refinement |
|
Date: |
Thu, 31 Jan 2008 18:49:00 +0100 |
|
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) |
Jim Meyering <address@hidden> writes:
> While making similar changes to sha256.c and especially sha512.c
> (where the 4 would become 8) in coreutils, I found changes like
> these to be essential:
>
> Use "sizeof VAR", rather than a literal "4".
> * lib/md5.c (md5_read_ctx): Use sizeof ctx->A, not 4.
> * lib/md4.c (md4_read_ctx): Likewise.
> * lib/sha1.c (sha1_read_ctx): Likewise.
>
> Simon?
Thanks, please install the patch.
The code duplication here suggests that the code could be re-factored...
although that would likely kill the possibility to merge patches back
into glibc eventually.
/Simon