[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix build failure with getline.c
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] fix build failure with getline.c |
Date: |
Sat, 02 Jan 2010 10:15:46 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> According to Robert Millan on 1/1/2010 4:24 PM:
>>> Aren't you using the gnulib stdio module, or is the code not working
>>> somehow?
>>>
>> So no, the stdio module wasn't being included. Maybe you want to consider
>> removing this dependency, I think other projects could be in a similar
>> situation than GRUB is.
>
> Removing the dependency seems like a step backwards. The point of the
> header replacement modules is so that the rest of the code can assume a
> compliant header. Glibc's header is not yet compliant to POSIX 2008, so
> importing the stdio module into GRUB seems like a better fix than changing
> getline.c in gnulib.
I agree. Remember that gnulib-tool offers two mechanisms that are
useful for maintainers who want to modify the recommended gnulib code
setup: --avoid to skip the stdio module, and --override to apply a local
patch to the code.
But using gnulib properly is more reliable, and will likely save you
work in the long run.
/Simon