Re: [PATCH 1/4] nonblocking: provide O_NONBLOCK for mingw

[Bruno Haible]

Eric Blake wrote:
> * lib/fcntl.in.h (O_NONBLOCK): Guarantee non-zero definition when
> nonblocking module is in use.

I think this deserves some comment. (It is documented in
doc/posix-headers/fcntl.texi but sometimes we are looking at the code only.)


2011-04-17  Bruno Haible  <address@hidden>

        nonblocking: Add comment.
        * lib/fcntl.in.h (O_NONBLOCK): Add comment.

--- lib/fcntl.in.h.orig Sun Apr 17 23:15:31 2011
+++ lib/fcntl.in.h      Sun Apr 17 23:03:20 2011
@@ -218,6 +218,9 @@
 # define O_NONBLOCK O_NDELAY
 #endif
 
+/* If the gnulib module 'nonblocking' is in use, guarantee a working non-zero
+   value of O_NONBLOCK.  Otherwise, O_NONBLOCK is defined (above) to O_NDELAY
+   or to 0 as fallback.  */
 #if @GNULIB_NONBLOCKING@
 # if O_NONBLOCK
 #  define GNULIB_defined_O_NONBLOCK 0

-- 
In memoriam Max Josef Metzger <http://en.wikipedia.org/wiki/Max_Josef_Metzger>