Re: [1/7] Proposed patches to remove several inttypes-related dependencies

[Eric Blake]

On 04/22/2011 03:54 AM, Paul Eggert wrote:
> Here's a series of proposed patches designed to remove unnecessary
> dependencies from gnulib's implementation of inttypes.h and related
> functions.

I've become accustomed to the habit of patch series with one patch per
email; it's easier to reply (when you lump it all into one email, git's
output puts "-- " after the first patch, so my mailer discards to the
other 6 patches as part of a giant signature), as well as discuss issues
for a single patch.

> +  AC_CHECK_DECLS_ONCE([strtoimax])
> +  if test "$ac_cv_have_decl_strtoimax" != yes; then
> +    HAVE_DECL_STRTOIMAX=0
> +
> +    AC_CACHE_CHECK([whether <inttypes.h> defines strtoimax as a macro],
> +      gl_cv_func_strtoimax_macro,
> +      [AC_EGREP_CPP([inttypes_h_defines_strtoimax], [#include <inttypes.h>
> +        #ifdef strtoimax
> +         inttypes_h_defines_strtoimax

How can the egrep check ever succeed if the declaration check (which
detects macros) failed?  You can further trim this .m4 file.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature