bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] gnulib-tool: fix imprecise comments


From: Stefano Lattarini
Subject: [PATCH] gnulib-tool: fix imprecise comments
Date: Tue, 13 Mar 2012 10:51:49 +0100

* gnulib-tool (func_emit_lib_Makefile_am): It's not just Automake
versions < 1.9b that creates an empty pkgdatadir at installation
time if pkgdata_DATA is specified to empty; modern automake versions
do this as well, and that's considered a feature, not a bug.  Adjust
a comment accordingly.
(func_emit_tests_Makefile_am): Likewise.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 ChangeLog   |   10 ++++++++++
 gnulib-tool |    8 ++++----
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3a114aa..817e1d9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2012-03-13  Stefano Lattarini  <address@hidden>
+
+       gnulib-tool: fix imprecise comments
+       * gnulib-tool (func_emit_lib_Makefile_am): It's not just Automake
+       versions < 1.9b that creates an empty pkgdatadir at installation
+       time if pkgdata_DATA is specified to empty; modern automake versions
+       do this as well, and that's considered a feature, not a bug.  Adjust
+       a comment accordingly.
+       (func_emit_tests_Makefile_am): Likewise.
+
 2012-03-12  Simon Josefsson  <address@hidden>
 
        Collapse list of copyright years to ranges.  See
diff --git a/gnulib-tool b/gnulib-tool
index eef9ab6..f99403d 100755
--- a/gnulib-tool
+++ b/gnulib-tool
@@ -3348,8 +3348,8 @@ func_emit_lib_Makefile_am ()
     echo "noinst_HEADERS ="
     echo "noinst_LIBRARIES ="
     echo "noinst_LTLIBRARIES ="
-    # Automake versions < 1.9b create an empty pkgdatadir at installation time
-    # if you specify pkgdata_DATA to empty. This is a workaround.
+    # By design, Automake creates an empty pkgdatadir at installation time
+    # if you specify pkgdata_DATA to empty.  So we need this workaround.
     if grep '^pkgdata_DATA *+=' "$tmp"/allsnippets > /dev/null; then
       echo "pkgdata_DATA ="
     fi
@@ -3669,8 +3669,8 @@ func_emit_tests_Makefile_am ()
       echo "check_LIBRARIES = libtests.a"
     fi
   fi
-  # Automake versions < 1.9b create an empty pkgdatadir at installation time
-  # if you specify pkgdata_DATA to empty. This is a workaround.
+  # By design, Automake creates an empty pkgdatadir at installation time
+  # if you specify pkgdata_DATA to empty.  So we need this workaround.
   if grep '^pkgdata_DATA *+=' "$tmp"/main_snippets "$tmp"/longrunning_snippets 
> /dev/null; then
     echo "pkgdata_DATA ="
   fi
-- 
1.7.9




reply via email to

[Prev in Thread] Current Thread [Next in Thread]