Re: quotearg test failures

[Padraig Brady]

On 10/18/2016 05:15 AM, Bruno Haible wrote:
>
> How about this? You are doing multiple passes through the argument string
> anyway now. (Originally quotearg was meant as a single-pass implementation,
> but it isn't any more.) So
>   - remove the code block of lines 711..720,
>   - instead, before the for(...) loop, determine all_c_and_shell_quote_compat
>     and encountered_single_quote in an extra single pass through the string,
>   - and put the code block from lines 711..720 *BEFORE* the for(...) loop.
>       
> This way, the buffer will only be filled once. => No buffer overrun.
>
> I'm reverting the unintented parts of test-sh-quote.c. You can then decide
> how you want to modify quotearg.c (and sh-quote.c if you want).

In the attached I added a single extra orig_buffersize variable to
control an extra read-only scan.

Pádraig.

fix-sh-quote.patch
Description: Text Data