bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-grep] doc bug in grep; PATTERN implies a regexp used in --inclu


From: Benno Schulenberg
Subject: Re: [bug-grep] doc bug in grep; PATTERN implies a regexp used in --include or --exclude
Date: Wed, 1 Dec 2004 13:04:25 +0100
User-agent: KMail/1.7.1

Stepan Kasal wrote:
> On Tue, Nov 30, 2004 at 07:55:39PM -0500, Jack Eidsness wrote:
> >   --include=PATTERN
>
> yes, you are right.  I suggest the following patch (incorporating
> Benno's changes).  Will it be OK?

--include and --exclude by themselves do not mean 'recurse', so the 
"Recurse in directories" is incorrect.  Both options also work when 
not recursing, so the info file should not mention "When processing 
directories recursively".  And --exclude does not skip directories 
that match the pattern, only files.  Attached is a patch that makes 
these changes.

On the exit codes: "0 if any line was selected" is not entirely 
correct: in the case of -q.  A better summary in my opinion would 
be "Exit status is 0 upon any match, 1 upon no match, and 2 if an 
error occurred (except when -q was given)".

And 'may be' is better than 'is' after all, as WHEN is optional, but 
at least the quote styles should match.

Benno

Attachment: grep--more-nits.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]