Re: [bug-grep] doc bug in grep; PATTERN implies a regexp used in --include or --exclude

[Stepan Kasal]

Hello,

On Wed, Dec 01, 2004 at 01:04:25PM +0100, Benno Schulenberg wrote:
> --include and --exclude by themselves do not mean 'recurse', so the 
> "Recurse in directories" is incorrect.  Both options also work when 
> not recursing, so the info file should not mention "When processing 
> directories recursively".

Right, I have accepted this.

> And --exclude does not skip directories 
> that match the pattern, only files.  Attached is a patch that makes 
> these changes.

But it should.  See the bug #11017 on savannah.
A longer explanation is in my comment on the rejected patch #3521 there.

> On the exit codes: "0 if any line was selected" is not entirely 
> correct: in the case of -q.

Well, my view is that the line was selected, but not printed.

> "Exit status is 0 upon any match, ..."

I'm not sure about the word "upon" here, a native speaker could judge us.

But I object to the phrase "upon any match", because it is not true if
`-v' was given.  That's why the phrase ``was selected'' was invented.

(The space change  "s/\. If/\.  If/"  was accepted.)

> And 'may be' is better than 'is' after all, as WHEN is optional, but 
> at least the quote styles should match.

I agree, but I have chosen the other quote style.

Attached please find an updated patch.

Stepan

grep-file-pattern2.patch
Description: Text document