bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] grep: add --warnings={always,never,auto}.


From: Paolo Bonzini
Subject: Re: [PATCH 1/3] grep: add --warnings={always,never,auto}.
Date: Fri, 27 Aug 2010 12:56:13 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5

On 08/27/2010 12:13 PM, Jim Meyering wrote:
     I have a fundamental aversion to making functionality like this new
     warning depend on whether a standard input or output stream is a TTY.
     Personally, I want my script to fail if I use a regexp that deserves
     a warning.

Me too, but this would be against POSIX, and I think it is also borderline to remove the warning only for POSIXLY_CORRECT. But I agree we can say in NEWS that the default for --warn may be changed in the future, just in case.

-    dfawarn ("character classes syntax is [[:space:]], not [:space:]");
+    dfawarn ("character class syntax is [[:space:]], not [:space:]");

You're the native speaker, so I'm not going to complain. :)

You're welcome to push the amended patchset!

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]