[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] grep: add --warnings={always,never,auto}.
From: |
Jim Meyering |
Subject: |
Re: [PATCH 1/3] grep: add --warnings={always,never,auto}. |
Date: |
Fri, 27 Aug 2010 23:05:02 +0200 |
Paolo Bonzini wrote:
> On 08/27/2010 12:13 PM, Jim Meyering wrote:
>> I have a fundamental aversion to making functionality like this new
>> warning depend on whether a standard input or output stream is a TTY.
>> Personally, I want my script to fail if I use a regexp that deserves
>> a warning.
>
> Me too, but this would be against POSIX, and I think it is also
> borderline to remove the warning only for POSIXLY_CORRECT. But I
> agree we can say in NEWS that the default for --warn may be changed in
> the future, just in case.
>
>> - dfawarn ("character classes syntax is [[:space:]], not [:space:]");
>> + dfawarn ("character class syntax is [[:space:]], not [:space:]");
>
> You're the native speaker, so I'm not going to complain. :)
>
> You're welcome to push the amended patchset!
Thanks. One final change was to mark the dfa_warn argument
for translation:
dfawarn (_("character class syntax is [[:space:]], not [:space:]"));
Now, I've pushed it.
We can adjust semantics separately.
- [PATCH 2/3] dfa: warn on [:space:] and similar, (continued)
- [PATCH 2/3] dfa: warn on [:space:] and similar, Paolo Bonzini, 2010/08/15
- [PATCH 3/3] tests: add test for warnings, Paolo Bonzini, 2010/08/15
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Jim Meyering, 2010/08/27
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Paolo Bonzini, 2010/08/27
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Paul Eggert, 2010/08/27
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Paolo Bonzini, 2010/08/30
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Paul Eggert, 2010/08/30
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Paolo Bonzini, 2010/08/31
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Jim Meyering, 2010/08/31
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}., Paolo Bonzini, 2010/08/31
- Re: [PATCH 1/3] grep: add --warnings={always,never,auto}.,
Jim Meyering <=