bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Run-time dynamic linking in grep


From: Jim Meyering
Subject: Re: Run-time dynamic linking in grep
Date: Fri, 21 Jan 2011 15:50:13 +0100

Gilles Espinasse wrote:

> Selon Reuben Thomas <address@hidden>:
>
> ...
>> To try to avoid duplicated work, I'll start with one. Attached, a
>> rebased patch for adding transparent decompression using zlib (this is
>> patch #7017). To avoid mixing issues, I have for now removed the
>> run-time dynamic linking of zlib.
>>
>>
>
>> +dnl Check for arguments
>> +AC_ARG_ENABLE(decompress,
>> + [  --disable-decompress            disable decompress],
>
> Would it not be more standard to use --{disable,enable}-zlib for the option?

Yes, thanks.
Especially if there is ever support for other decompressors.
Of course, you an infer that the variable names in main.c
should be adapted accordingly.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]