Re: Run-time dynamic linking in grep

[Reuben Thomas]

On 21 January 2011 14:52, Jim Meyering <address@hidden> wrote:
> Reuben Thomas wrote:
>
>> On 21 January 2011 14:48, Gilles Espinasse <address@hidden> wrote:
>>> Selon Reuben Thomas <address@hidden>:
>>>
>>> ...
>>>> To try to avoid duplicated work, I'll start with one. Attached, a
>>>> rebased patch for adding transparent decompression using zlib (this is
>>>> patch #7017). To avoid mixing issues, I have for now removed the
>>>> run-time dynamic linking of zlib.
>>>>
>>>>
>>>
>>>> +dnl Check for arguments
>>>> +AC_ARG_ENABLE(decompress,
>>>> + [  --disable-decompress            disable decompress],
>>>
>>> Would it not be more standard to use --{disable,enable}-zlib for the option?
>>
>> The idea is to extend this to other compression libraries, so the name
>> should be general.
>
> The configure-time option should be capable of suppressing
> the use of zlib, independent of what other compression libraries are
> being used.

Quite right, the configure options should be per-library, but...

> However, if the grep-command-line option, --decompress, is intended
> to be generic, then the variables in main can remain the same.

...what he said.

-- 
http://rrt.sc3d.org