Re: [PATCH 33/34] maint: dfa: simplify multi-byte-related conditionals

[Paolo Bonzini]

On 09/15/2011 12:28 PM, Jim Meyering wrote:
> * src/dfa.c (setbit_case_fold_c, parse_bracket_exp, lex):
> (addtok_mb, dfaparse): Change each "MBS_SUPPORT&&  MB_CUR_MAX>  1"
> test to just "MB_CUR_MAX>  1".
> * src/dfasearch.c (kwsincr_case, EGexecute): Likewise.
> * src/kwsearch.c (Fcompile, Fexecute): Likewise.
> * src/searchutils.c (kwsinit): Likewise.
> * src/dfa.c (parse_bracket_exp): Convert
> "if (!MBS_SUPPORT || MB_CUR_MAX<= 1)" to
> "if (MB_CUR_MAX<= 1)" and do this:
> -      assert(!MBS_SUPPORT || MB_CUR_MAX == 1);
> +      assert(MB_CUR_MAX == 1);

I think this is wrong.  If you compile with !MBS_SUPPORT, grep must 
behave as if MB_CUR_MAX == 1 always.

Paolo