bug-grep
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/34] maint: dfa: convert #if-MBS_SUPPORT (copytoks)

From: Paolo Bonzini
Subject: Re: [PATCH 16/34] maint: dfa: convert #if-MBS_SUPPORT (copytoks)
Date: Thu, 15 Sep 2011 13:28:21 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 
On 09/15/2011 01:21 PM, Jim Meyering wrote:

>>  +#if MBS_SUPPORT
>>     static void
>>     add_utf8_anychar (void)
>>     {

>
>  Why keep the #if here?  I think you're relying on compile-time dead
>  code elimination.


That particular #if directive is removed in a subsequent patch.


Agreed, but I prefer squashing that patch where it would naturally apply.

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]