|
| From: | Paolo Bonzini |
| Subject: | Re: [PATCH 01/34] maint: convert #if-MBS_SUPPORT (kwsinit) |
| Date: | Thu, 15 Sep 2011 13:29:09 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/15/2011 01:07 PM, Stefano Lattarini wrote:
Maybe I'm missing something fundamental, but this looks defintely wrong
to me. The code guarded by this "if" will now never be run when
MBS_SUPPORT is 0, while previously is was run if `match_icase' was 1
and MBS_SUPPORT was 0. Maybe you intended to use like this instead?
if (match_icase&& (!MBS_SUPPORT || MB_CUR_MAX == 1)) { ... }
Good catch. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |