bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/34] maint: dfa: convert #if-MBS_SUPPORT (free_mbdata)


From: Jim Meyering
Subject: Re: [PATCH 09/34] maint: dfa: convert #if-MBS_SUPPORT (free_mbdata)
Date: Thu, 15 Sep 2011 14:01:08 +0200

Paolo Bonzini wrote:
> On 09/15/2011 12:27 PM, Jim Meyering wrote:
>> From: Jim Meyering<address@hidden>
>>
>> * src/dfa.c (free_mbdata): Use regular "if", not #if MBS_SUPPORT.
>> ---
>>   src/dfa.c |   47 ++++++++++++++++++++++++-----------------------
>>   1 files changed, 24 insertions(+), 23 deletions(-)
>>
>> diff --git a/src/dfa.c b/src/dfa.c
>> index 30013a2..acd99aa 100644
>> --- a/src/dfa.c
>> +++ b/src/dfa.c
>> @@ -3407,38 +3407,39 @@ dfaexec (struct dfa *d, char const *begin, char *end,
>>       }
>>   }
>>
>> -#if MBS_SUPPORT
>>   static void
>>   free_mbdata (struct dfa *d)
>>   {
>> -  unsigned int i;
>> +  if (MBS_SUPPORT)
>> +    {
...
>> +    }
>>   }
>> -#endif
>>
>>   /* Initialize the components of a dfa that the other routines don't
>>      initialize for themselves. */
>
> Either here or later in the series, this if can be removed.

Good catch.  I've removed it there -- and adjusted the log, of course.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]