[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp) |
|
Date: |
Fri, 16 Sep 2011 08:50:45 +0200 |
Jim Meyering wrote:
> Paolo Bonzini wrote:
>> On 09/15/2011 12:27 PM, Jim Meyering wrote:
>>> --- a/src/dfa.c
>>> +++ b/src/dfa.c
>>> @@ -1025,34 +1025,33 @@ parse_bracket_exp (void)
>>>
>>> colon_warning_state |= (c == ':') ? 2 : 4;
>>>
>>> -#if MBS_SUPPORT
>>> - if (MB_CUR_MAX> 1)
>>> + if (!MBS_SUPPORT || MB_CUR_MAX<= 1)
>>
>> Can test == 1.
>
> The answer is obvious, so perhaps I'm misunderstanding.
> That expression will be 1 e.g., whenever MBS_SUPPORT is 0
Perhaps you're really asking whether MB_CUR_MAX can be smaller than 1 ?
That bothered me, too, so I made it consistent with the others, using "=="
rather than "<=".
[PATCH 27/34] build: enable compilation without MBS_SUPPORT, Jim Meyering, 2011/09/15
[PATCH 19/34] maint: dfa: convert #if-MBS_SUPPORT (dfastate), Jim Meyering, 2011/09/15
[PATCH 29/34] maint: stop using skip_test_; use skip_ instead, Jim Meyering, 2011/09/15
[PATCH 11/34] maint: dfa: convert #if-MBS_SUPPORT (dfaexec), Jim Meyering, 2011/09/15
[PATCH 34/34] maint: dfa: remove case-guarding #if-MBS_SUPPORT, Jim Meyering, 2011/09/15
[PATCH 22/34] maint: ensure that MB_CUR_MAX is defined even when !MBS_SUPPORT, Jim Meyering, 2011/09/15