Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket

bug-grep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp

From:	Paolo Bonzini
Subject:	Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp)
Date:	Fri, 16 Sep 2011 11:55:14 +0200
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/15/2011 07:52 PM, Jim Meyering wrote:

>>  -#if MBS_SUPPORT
>>  -      if (MB_CUR_MAX>   1)
>>  +      if (!MBS_SUPPORT || MB_CUR_MAX<= 1)

>
>  Can test == 1.


The answer is obvious, so perhaps I'm misunderstanding.
That expression will be 1 e.g., whenever MBS_SUPPORT is 0


I meant you can test for MB_CUR_MAX == 1 rather than <=. :)

Paolo

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 21/34] maint: dfa: remove some #if MBS_SUPPORT guards, (continued)
- [PATCH 05/34] maint: remove #if-MBS_SUPPORT declaration guards, Jim Meyering, 2011/09/15
- [PATCH 26/34] tests: skip tests that require MBS support, Jim Meyering, 2011/09/15
  - Re: [PATCH 26/34] tests: skip tests that require MBS support, Paolo Bonzini, 2011/09/15
    - Re: [PATCH 26/34] tests: skip tests that require MBS support, Jim Meyering, 2011/09/15
    - Re: [PATCH 26/34] tests: skip tests that require MBS support, Paolo Bonzini, 2011/09/15
- [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp), Jim Meyering, 2011/09/15
  - Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp), Paolo Bonzini, 2011/09/15
    - Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp), Jim Meyering, 2011/09/15
    - Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp), Jim Meyering, 2011/09/16
    - Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp), Paolo Bonzini <=
- [PATCH 27/34] build: enable compilation without MBS_SUPPORT, Jim Meyering, 2011/09/15
  - Re: [PATCH 27/34] build: enable compilation without MBS_SUPPORT, Paolo Bonzini, 2011/09/15
- [PATCH 19/34] maint: dfa: convert #if-MBS_SUPPORT (dfastate), Jim Meyering, 2011/09/15
- [PATCH 29/34] maint: stop using skip_test_; use skip_ instead, Jim Meyering, 2011/09/15
- [PATCH 11/34] maint: dfa: convert #if-MBS_SUPPORT (dfaexec), Jim Meyering, 2011/09/15
- [PATCH 34/34] maint: dfa: remove case-guarding #if-MBS_SUPPORT, Jim Meyering, 2011/09/15
- [PATCH 22/34] maint: ensure that MB_CUR_MAX is defined even when !MBS_SUPPORT, Jim Meyering, 2011/09/15
  - Re: [PATCH 22/34] maint: ensure that MB_CUR_MAX is defined even when !MBS_SUPPORT, Paolo Bonzini, 2011/09/15
    - Re: [PATCH 22/34] maint: ensure that MB_CUR_MAX is defined even when !MBS_SUPPORT, Paolo Bonzini, 2011/09/15
    - Re: [PATCH 22/34] maint: ensure that MB_CUR_MAX is defined even when !MBS_SUPPORT, Jim Meyering, 2011/09/15

Prev by Date: Re: [PATCH 08/34] maint: dfa: convert #if-MBS_SUPPORT (dfaoptimize, dfacomp)
Next by Date: Re: dfa/MBS_SUPPORT cleanup
Previous by thread: Re: [PATCH 13/34] maint: dfa: convert #if-MBS_SUPPORT (parse_bracket_exp)
Next by thread: [PATCH 27/34] build: enable compilation without MBS_SUPPORT
Index(es):
- Date
- Thread