[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18777: [PATCH] dfa: improvement for checking of multibyte character
From: |
Norihiro Tanaka |
Subject: |
bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary |
Date: |
Wed, 17 Dec 2014 08:22:20 +0900 |
On Tue, 16 Dec 2014 09:12:21 -0800
Paul Eggert <address@hidden> wrote:
>
> This part of the patch does too much work, as the caller inspects *WCP
> only when skip_remains_mb returns a value not equal to p. So there's
> no need for the "wcp == NULL &&" test in the patch. Instead, the
> documented API can change, saying that *WCP is assigned to only if WCP
> is non-NULL and the result is greater than p.
Thanks, you are right. However, first it is no longer portable after
remove it. Second if it is compiled with GCC 4.3 or later, the function
is inlined by and "WCP == NULL &&" will be pruned.
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Norihiro Tanaka, 2014/12/15
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Paul Eggert, 2014/12/15
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Norihiro Tanaka, 2014/12/16
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Paul Eggert, 2014/12/16
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary,
Norihiro Tanaka <=
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Paul Eggert, 2014/12/16
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Norihiro Tanaka, 2014/12/17
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Paul Eggert, 2014/12/17
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Norihiro Tanaka, 2014/12/17
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Paul Eggert, 2014/12/18
- bug#18777: [PATCH] dfa: improvement for checking of multibyte character boundary, Norihiro Tanaka, 2014/12/18