bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not


From: Jim Meyering
Subject: bug#24159: [PATCH] dfa: minor fix for whether dfa is fast or not
Date: Fri, 5 Aug 2016 13:29:43 -0700

On Fri, Aug 5, 2016 at 4:30 AM, Norihiro Tanaka <address@hidden> wrote:
> dfaoptimize() is not set fast flag even if it is success, but it is wrong.
> If success, dfa matcher uses algorithm for single byte, and it is so fast.
>
> I think this bug does not affect for grep, but it will affect with the
> patch that I just sent to gawk.

Thank you for the patch.
I was going to push it with the attached slightly updated log message.
Note however that grep does use that -> fast member via dfasearch.c's
use of the dfaisfast function.
But then I realized I should at least verify with "make check", and
found that this makes grep's dfa-match test fail.
Thus, I will not be pushing it as-is.

Attachment: 0001-dfa-minor-fix-for-whether-dfa-is-fast.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]