Re: [bug #44768] gdiffmk(1) is not Solaris 10 /bin/sh compatible - PATCH provided

[Mike Bianchi]

On Tue, Apr 14, 2015 at 11:28:29PM +0200, Werner LEMBERG wrote:
> 
> >> I think the best and most portable approach would be to have the
> >> autoconf infrastructure find and substitute in appropriate default
> >> values for DIFFCMD and SEDCMD via address@hidden@ and address@hidden@,
> >> I know that is how grep(1) and egrep(1) is handled by the groff
> >> project currently.
> >> 
> >> My guess is that we would need to add something to configure.ac,
> >> and maybe a makefile to make this happen.
> > 
> > Werner, can you point me at something that would explain turning
> > gdiffmk.sh into something autoconf would manage?
> 
> It is already managed; you only have to extend it.
> 
> 1. In configure.ac (or in m4/groff.m4) a test for the `diff' program
>    is needed, probably using AC_CHECK_PROGS; autoconf doesn't provide
>    something in advance – note that the `configure' script itself
>    already needs the `diff' program, but it doesn't provide a macro;
>    it simply assumes that it is available in the path.  `sed' is
>    covered by AC_PROG_SED.
> 
> 2. In gdiffmk.sh, use @SED@ and @DIFF@ (or whatever symbols are
>    actually used in configure.ac) instead of `sed' and `diff'.
> 
> 3. In the sub-makefile `contrib/gdiffmk/gdiffmk.am' you have to extend
>    the `gdiffmk' rule to substitute @SED@ and @DIFF@ with its real
>    values.
> 
> 
>     Werner

I found code at the top of  contrib/pdfmark/pdfroff.sh  that manages
cat, grep and sed, and other portability issues, but what a tangle!

I'm inclined to  commit  what I have and move on, since I don't have the time
to untie that knot.

        Is that acceptable?

-- 
 Mike Bianchi
 Foveal Systems

 973 822-2085

 address@hidden
 http://www.AutoAuditorium.com
 http://www.FovealMounts.com