[bug #44768] gdiffmk(1) is not Solaris 10 /bin/sh compatible - PATCH provided

[Peter Bray]

Follow-up Comment #20, bug #44768 (project groff):

Bertrand, Werner & Mike,

Patch applied and tested on Solaris 10 Update 10 (X86_64).

Notes

  1. configure choose Solaris' diff implementation as it has -D

  2. bug_44768_diff_sh_sed.patch.test-suite.log is the test-suite.log
     from applying the patch and testing from a "gmake dist" tarball

  3. bug_44768_diff_sh_sed.patch.with-gdiff.test-suite.log is the
     test-suite.log, of the patch with the ./gdiffmk updated to use
     "gdiff" as its diff command. No other changes.

  4. GNU diff and Solaris diff's -D options diff in the closing comment
     with GNU diff placing a ! in front of the condition name.
     See Attached: diff_-D_XXXXXXs-side-by-side and the raw files
     diff_-D_XXXXXX_file1_file2.diff_solaris and
     gdiff_-D_XXXXXX_file1_file2.diff_gnu

  5. Back in followup-notes-2 (comment 16) I started writing that I thought
     was the ! as Bertrand assumed, and like Bertrand I looked at the doco,
     in my case the "sed and awk Pocket Reference" and Solaris 10 sed(1)
     manual page, but as stated ! was implemented. See
sed.manual-page-selected

  6. I started this point with I think is the regexp it is breaking on, BUT
     then I tested further, concluded that the regexp is not the problem.

% echo '#else /* XXXX'
#else /* XXXX

% echo '#else /* XXXX'  |  sed -e '/^#else /* XXXX/ p'
#else /* XXXX
#else /* XXXX

% echo '#else /* XXXX'  | gsed -e '/^#else /* XXXX/ p'
#else /* XXXX
#else /* XXXX

  7. I think it is the second part of the line, as in the following:

% echo '#else /* XXXX'  | sed -e '/^#else /* XXXX/ { p }'
sed: command garbled: /^#else /* XXXX/ { p }

% echo '#else /* XXXX'  | gsed -e '/^#else /* XXXX/ { p }'
#else /* XXXX
#else /* XXXX

      but I don't have the time today to move this further along.
      I'll submit this as is and try and find show time in the next
      day or so.

Regards,
Peter


(file #33793, file #33794, file #33795, file #33796)
    _______________________________________________________

Additional Item Attachment:

File name: bug_44768_diff_sh_sed.patch.test-suite.log Size:2 KB
File name: bug_44768_diff_sh_sed.patch.test-suite.log Size:2 KB
File name: gdiff_-D_XXXXXX_file1_file2.diff_gnu Size:0 KB
File name: diff_-D_XXXXXX_file1_file2.diff_solaris Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44768>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/