Re: FreeBSD loader options patch

[Alexander Langer]

Thus spake Yoshinori K. Okuji (address@hidden):

> > Please see attached patch which adds support for a few options that
> > the FreeBSD-CURRENT loader is able to understand.
> You define RB_POWEROFF but don't use it at all. Also, I took a look at
> sys/reboot.h and boot/i386/libi386/bootinfo.c in FreeBSD-CURRENT, and
> found that FreeBSD itself didn't set RB_POWEROFF, either. Is this a
> bug in FreeBSD? Or, is the feature RB_POWEROFF being implemented?

I only added that line so people don't wonder why 0x4000 is left out
while all others are used.  Remove that line, if you want.  It's not
used in GRUB and won't ever.

The RB_* commands were args to the reboot system call before, used from
within reboot(8).  Here the poweroff flag makes sense.  I can't see a
real usage for booting a kernel just to power the system off ;-)
(Neither did I saw a reason to add support for all the other parameters
I left out - we defenitely don't need that stuff in GRUB)

Ciao

Alex

PS: There is currently an isse with NetBSD, which uses a different
struct bootinfo layout than FreeBSD.  I ran into this problem when
trying to tell the NetBSD kernel to use serial console, which failed
since it doesn't understand FreeBSD's struct bootinfo - so basically
GRUB must not share the same sources for FreeBSD and NetBSD there (at
least that's the case for NetBSD 1.6).  One should fix that.  I might
be able to do it once I have my diskless workstation running and some
more time to actually do it ;-)