Re: [bug-gtypist] GTypist 2.9 package

[Felix Natter]

Daniel Leidert <address@hidden> writes:

hello Daniel,

> Am Montag, den 14.11.2011, 09:31 +0100 schrieb Felix Natter:
>> hi Daniel,
>> 
>> there is a small problem with your gtypist 2.9 package: Why do you depend on
>> libncurses?
>
> The package depends on libncursesw5 not libncurses5.

I think it depends on both (from http://packages.debian.org/sid/gtypist).

> The configure script checks for it and prefers ncursesw over ncurses.
> JFTR: The configure script *only* checks for ncursesw, so everything
> beyond this point in configure.ac doesn't make sense to me. There is no
> check for ncurses, so the case that both will be found cannot happen.
> Check out this piece of code:
>
>> #AC_CHECK_HEADER(curses.h, HAVE_CURSES_H=1)
>> AC_CHECK_HEADER(ncursesw/ncurses.h, HAVE_NCURSESW_H=1)
>> 
>> # We prefer ncurses to curses if both are found.
>> dnl if test -n "$HAVE_NCURSES_H" -a -n "$HAVE_LIBNCURSES";  then
>> dnl    LIBS="-lncurses $LIBS"
>> dnl elif test -n "$HAVE_CURSES_H" -a -n "$HAVE_LIBCURSES"; then
>> dnl    LIBS="-lcurses $LIBS"
>> if test -n "$HAVE_NCURSESW_H" -a -n "$HAVE_LIBNCURSESW";  then
>>        LIBS="-lncursesw $LIBS"
>> else
>>    echo -e "Error:  both library and header files for ncursesw"\
>>         "library\nis required to build this package.  See INSTALL file for"\
>>         "further information."
>>    exit 1;
>> fi

Yes, the comments are useless and I'have just commited a change to
remove this from git. GTypist used to support BSD Curses as an
alternative to ncurses, but currently we're using ncursesw on all
platforms except Win32 (where we use PDCurses). It was not ncurses vs
ncursesw, it was just ncurses vs (BSD-)curses because gtypist <2.9
did not support wide characters (unicode) at all.

But those are just comments, they shouldn't affect the correctness of
the debian (source) package. Of course we can make a 2.9.1 release
if that is needed.

> [..]
>> (same for the source package)
>
> Indeed the source depends on both ncurses variants. It will be fixed
> with the next upload.

Ok, thanks.

> BTW: If your related to gtypist upstream sources, would you mind
> checking out the open bug reports here:
> http://bugs.debian.org/src:gtypist

Yes, sure, we have taken care of most of them already, but we should
definitely close all of them ASAP.

#179784 (gtypist: option to enable wordwrapping)
=> we'll probably fix this for 2.10, I hope the user is still with us
:-)

#325565 (gtypist: request inclusion of ktouch2typ.pl) 
=> can you take care of that? Please also include
"tools/ktouchOLD2typ.pl", it is also referenced in the manual.

#358420 (typefortune: pressing 'N' and 'SPACE' quits instead of
 continue)
=> the user started "typefortune" without arguments which just creates
1 drill from "fortune", and the generated script clearly indicates
that the lessons are done:
"Congratulations: you successfully completed the 1 fortune lessons !"
When you press SPACE/ENTER the program terminates, which I think is
to be expected.
=> can be closed

#220581 (gtypist: VIM syntax highlighting)
=> as of ~2000-2003, RMS does not allow/want us to include the VIM Syntax
highlighting mode in the package. What is the debian policy on this,
maybe we should include it in the debian package? Has licencing
changed?

Thanks and Best Regards,
-- 
Felix Natter