bug-idutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-idutils] idutils.el and Emacs 22


From: Jim Meyering
Subject: Re: [bug-idutils] idutils.el and Emacs 22
Date: Thu, 21 Jun 2007 15:52:24 +0200

Tom Tromey <address@hidden> wrote:

> Emacs 22 comes with an updated compilation mode.  I've changed
> idutils.el to work with it; new version appended.
>
> Changes are:
>
> * Uses define-compilation-mode
> * Sets gid-mode-font-lock-keywords so that the initial "Gid started"
>   message is not treated as a hit to find
> * Uses compilation-start so that the hits are highlighted properly
>   on next-error
> * I didn't like how buffers were named after the search -- I just
>   started using gid (what was I thinking all those years?  This is a
>   great tool!) -- and I was surprised to find a lot of old *gid-FOO*
>   buffers around
> * Now uses thing-at-point
>
> Anybody considered trying to get this code into Emacs rather than
> shipping it in idutils?

I haven't, but if you're inclined, please do!

> 2007-06-19  Tom Tromey  <address@hidden>
>
>       * lisp/idutils.el: Require thingatpt.
>       (gid-mode-font-lock-keywords): New variable.
>       (gid-mode): New mode.
>       (gid): Use compilation-start, thing-at-point.
>       (word-around-point): Removed.

Thanks, Tom.
Welcome to idutils :-)

I like all of your changes except for the part that suppresses creation
of a per-invocation *gid-FOO* buffer in favor of a single "*gid*" buffer.

Believe it or not, having *gid-FOO*, *gid-BAR*, *gid-BAZ*, etc. buffers
simultaneously is a feature :-)  Imagine you're iterating through the uses
of FOO, but then realize you also need to consider all of the uses of BAR.
With your change, running gid on BAR would destroy the compilation buffer
that was preserving your position in the list of all FOO uses.

If you redo the patch to preserve that feature, I'll be happy to apply it.

Jim




reply via email to

[Prev in Thread] Current Thread [Next in Thread]