[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fixing broken djgpp support in make 3.81
From: |
Paul Smith |
Subject: |
Re: Fixing broken djgpp support in make 3.81 |
Date: |
Mon, 14 Jan 2008 20:54:31 -0500 |
On Tue, 2008-01-15 at 01:32 +0100, Juan Manuel Guerrero wrote:
> /* Handle other OSs. */
> #ifndef PATH_SEPARATOR_CHAR
> # if defined(HAVE_DOS_PATHS)
> # define PATH_SEPARATOR_CHAR ';'
> # define IS_PATHSEP(c) ((c) == '/' || (c) == '\\')
> # define HAVE_DRIVE(n) ((n)[0] && (n)[1] == ':')
> # elif defined(VMS)
> # define PATH_SEPARATOR_CHAR ','
> # define IS_PATHSEP(c) ((c) == ']')
> # else
> # define PATH_SEPARATOR_CHAR ':'
> # define IS_PATHSEP(c) ((c) == '/')
> # endif
> #endif
Hi Juan; it's great to have someone paying some attention to this port
again. It seems like the amount of change you've made will require
copyright assignment. I see you've already done some of these, for
Bison etc., but if you need paperwork let me know.
As for the above, I wonder whether it might be useful to add:
# define HAVE_DRIVE(n) 0
for the non-HAVE_DOS_PATHS sections of the above ifdef. That would
allow us to use HAVE_DRIVE(foo) without enclosing it in ifdefs for DOS
etc., and still have the compiler omit the code (via optimization of
always-false values).
--
-------------------------------------------------------------------------------
Paul D. Smith <address@hidden> Find some GNU make tips at:
http://www.gnu.org http://make.mad-scientist.us
"Please remain calm...I may be mad, but I am a professional." --Mad Scientist