Re: [Bug-parted] Re: parted 1.3.x errata

[Damien Genet]

Salut


Damien Genet wrote:
> Andrew Clausen wrote:
> > > the func should, maybe, return true to PED_PARTITION_HIDDEN
> > > only for FAT, and false for PED_PARTITION_BOOT when
> > > partition is extended.
> > 
> > Hmmm.  I guess I should do this :-/  It's ugly.  Added to TODO,
> > pending further sleepness nights.
> 
> I join a diff, code is untested (Gtk-Parted is still broken due to
> libparted 1.3.x port), modifications should also be applied
> to disk_pc98, but I don't know how much this architecture
> (is it the right word?) differs from a standard PC.

Oops, I just see that file wasn't attach (?!)...
But the modification was buggy, I update it.
I include the function in the mail, so attachement can't disapear,
(I think, last time I shutdown my samba server, where file was,
before sending the mail, but...)

---

static int
msdos_partition_is_flag_available (const PedPartition* part,
              PedPartitionFlag flag)
{
 DosPartitionData* dos_data;

 PED_ASSERT (part != NULL, return 0);
 PED_ASSERT (part->disk_specific != NULL, return 0);

 dos_data = part->disk_specific;

 switch (flag) {
 case PED_PARTITION_HIDDEN:
  if (part->fs_type)
   if ( strcmp(part->fs_type->name, "FAT") )
    return 0;
  else
   return 0;
 case PED_PARTITION_BOOT:
  if (part->type == PED_PARTITION_EXTENDED)
   return 0;
 case PED_PARTITION_RAID:
 case PED_PARTITION_LVM:
 case PED_PARTITION_LBA:
  return 1;

 default:
  return 0;
 }
}

---

It's also a bit strange, all tabulations disapeared,
I hope Evolution will be coming soon :)


Dam