Re: When should I replay a journal ?

[Andrew Clausen]

On Mon, Oct 04, 2004 at 11:45:56AM +0200, K.G. wrote:
> Hi,
> 
> I'm implementing the journal for HFS+, and I think I can replay
> transactions at two differents places, either when checking the
> filesystem, or when opening it. If I replay when opening, this means the
> FS could be modified by things as simple as 'print $part'. Is that good
> ? Does the user knows and wants that this happens ? On the other way,
> putting it in the check part means printing the partition could report
> inaccurate informations... Maybe I should put it in 'open' with an
> exception asking the user if he wants transactions to be replayed ?

Check should throw an exception saying the filesystem wasn't
cleanly unmounted, right?

How long is the code to replay the journal?

The paranoia in me is inclined to say: strongly encourage the user
to reboot and get OSX to replay the journal.  Unless you are
really confident about how safe your journal replay code is.

Cheers,
Andrew