Re: Removing "pointless" exception for exotic block devices causes probe to find CDs

[Woody Suwalski]

Colin Watson wrote:
> On Sat, Dec 04, 2004 at 11:24:07PM +1100, Andrew Clausen wrote:
>
> > On Sat, Dec 04, 2004 at 11:38:30AM +0000, Colin Watson wrote:
> >
> > > It'd be nice if this were flagged as an interface change, though.
> >
> > What do you mean?
>
>
> Well, ped_device_probe_all() followed by repeated ped_device_get_next()
> returns different results as of 1.6.19 which are usually not what
> partitioning user interfaces want, and applications need to be aware of
> that change.
>
> Cheers,

I have mentioned the same problem to Andrew long time ago....

I suggested restoring (inside parted) checking if the IOCTL GetGeometry 
fails.
If it fails: either it is a CD drive, or device which parted should not 
touch either, so the disk should not be added to the list.

For now I have implemented a simpler patch - disabled inside parted a 
call to "probe_standard_devices", so that what is left is 
/proc/partition info. Works for me - no CD drives there...


Woody