Re: Removing "pointless" exception for exotic block devices causes probe to find CDs

[Woody Suwalski]

Andrew Clausen wrote:
> On Sat, Dec 04, 2004 at 10:02:40AM -0500, Woody Suwalski wrote:
>
> > I have mentioned the same problem to Andrew long time ago....
> >
> > I suggested restoring (inside parted) checking if the IOCTL GetGeometry 
> > fails.
> > If it fails: either it is a CD drive, or device which parted should not 
> > touch either, so the disk should not be added to the list.
> >
> > For now I have implemented a simpler patch - disabled inside parted a 
> > call to "probe_standard_devices", so that what is left is 
> > /proc/partition info. Works for me - no CD drives there...
>
>
> Is there any reason why checking "dev->read_only" wouldn't work?
>
> Cheers,
> Andrew
Probably it would work. I have an application walking ped_disks 
structure, so will need to change it's logic (it is similar to Colin's 
problem). Maybe next version...

Still there is no point in including in the parted's disk list CDROMs or 
devices with no geometry... None of these will ever be used as a 
repartitioning target...

Woody