Re: [bug-patch] Upcoming stable release

[Andreas Gruenbacher]

On Tuesday, 7 April 2009 0:16:42 Mike Frysinger wrote:
> plans to include a second tarball (xz) ?

For the alphas? Probably not unless someone convinces me otherwise.

> > The code should be feature complete for the next stable release with only
> > a few minor bugfixes left in the queue.  This is your chance to report
> > more bugs that still need to be addressed.
>
> out of tree build fails: mkdir foo ; cd foo ; ../configure ; make

Fixed.

> warning when building on 64bit systems because util.c uses unsigned int but
> hash.c expects size_t:
> src/util.c: In function ‘init_backup_hash_table’:
> src/util.c:84: warning: passing argument 3 of ‘hash_initialize’ from
> incompatible pointer type

Gnulib fallout, also fixed.

> > * The --binary option disables the heuristic for stripping CRs from
> >   line endings in patches.  This allows to preserve CRs even in mangled
> >   patches, or in patches generated without the --binary option on
> > non-POSIX systems.
>
> so was the heuristic improved after the last thread on the topic ?

There was much arguing back and forth with some misunderstandings, but no 
winning proposal. In the end, I sticked with turning off CRLF stripping 
with --binary when reading. I updated the man page to:

       --binary
          Write  all  files  in  binary  mode,  except for standard output and
          /dev/tty.  When reading, disable the heuristic for transforming CRLF
          line  endings  into  LF line endings.  (On POSIX-conforming systems,
          reads and writes never transform line endings. On systems like  DOS,
          reads  and  writed do transform line endings by default, and patches
          should be generated by diff --binary when line endings are  signifi‐
          cant.)

Thanks,
Andreas