[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-sysutils] argp patch for cppw.c
From: |
Marco Gerards |
Subject: |
Re: [Bug-sysutils] argp patch for cppw.c |
Date: |
Fri, 04 Jun 2004 20:10:13 +0200 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
Barry deFreese <address@hidden> writes:
> OK, here are the argp changes for cppw.c. It builds and seems to work
> properly. I'm getting a little better.. :-)
Great!
> + case 'p':
> + if (args->passwd == 0) {
> + fprintf(stderr,
> + _("%s: `-p' cannot be combined with `-g'\n"
> + "Try `%s --help' for more information.\n"),
> + progname, progname);
> + return -1;
Please correct me if I am wrong, but IIRC the return type of this
function is error_t. Better use a macro (EINVAL perhaps?) instead of
-1. Another thing you might want to do is calling `argp_usage'.
--
Marco
- Re: [Bug-sysutils] argp patch for cppw.c,
Marco Gerards <=