Re: [Bug-sysutils] argp patch for cppw.c

[David Weinehall]

On Fri, Jun 04, 2004 at 08:10:13PM +0200, Marco Gerards wrote:
> Barry deFreese <address@hidden> writes:
> 
> > OK, here are the argp changes for cppw.c.  It builds and seems to work
> > properly.  I'm getting a little better.. :-)
> 
> Great!
> 
> > +   case 'p':
> > +           if (args->passwd == 0) {
> > +                   fprintf(stderr,
> > +                           _("%s: `-p' cannot be combined with `-g'\n"
> > +                             "Try `%s --help' for more information.\n"),
> > +                           progname, progname);
> > +                   return -1;
> 
> Please correct me if I am wrong, but IIRC the return type of this
> function is error_t.  Better use a macro (EINVAL perhaps?) instead of
> -1.  Another thing you might want to do is calling `argp_usage'.

The merged code does use argp_usage and has various other changes as
well.  I've been holding back the merges of Barry's code, since he
hadn't received an ack from the FSF about his copyright assignment, but
now he's received it, hence I'll merge my CVS backlog this weekend.
Don't expect anything today though; it's 21.30 and still 20 degrees
Celsius outside, so I'm going to enjoy the weather...


Regards: David
-- 
 /) David Weinehall <address@hidden> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/