Re: [Bug-sysutils] argp patch for chfn.c

[David Weinehall]

On Fri, Jun 04, 2004 at 08:19:49PM +0200, Marco Gerards wrote:
> Barry deFreese <address@hidden> writes:
> 
> > OK, here are the argp updates for chfn.
> 
> It looks fine to me (well, I had a really quick look).  This is
> something minor, instead of this code:
> 
> > +   case ARGP_KEY_INIT:
> > +           args->user = NULL;
> > +           args->fname = NULL;
> > +           args->room = NULL;
> > +           args->wphone = NULL;
> > +           args->hphone = NULL;
> > +           args->other = NULL;
> > +           break;
> 
> You can change this...
> 
> > +   struct arguments args;
> 
> Into this...
> 
> struct arguments args = { 0 };
> 
> Ok, I have not tested this, but it should work. ;)

Yes, but explicit initialisation has the advantage of being
self-explanatory =)


Regards: David Weinehall
-- 
 /) David Weinehall <address@hidden> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/