Re: [Bug-sysutils] argp patch for chsh

[David Weinehall]

On Fri, Jun 04, 2004 at 08:27:36PM +0200, Marco Gerards wrote:
> Barry deFreese <address@hidden> writes:
> 
> > Whoops, I was missing my .cvsrc on that last one.  Here is a diff -u
> > copy.. Sorry.
> 
> Great!  Keep up the good work. :)
> 
> >     /* If we have no options, enter interactive mode */
> > -   if (optind == 1) {
> > +   if (argc == 1) {
> >             fprintf(stdout,
> >                     _("Changing the login shell for `%s'\n"
> >                       "Enter the new value, or press enter to keep "
> 
> I don't fully understand the code, but in this case interactive mode
> (right?)  is not used when I run `chsh marco'.  How about using this:
> 
> if (args->shell == NULL)

Fixed in my local tree.


Regards: David Weinehall
-- 
 /) David Weinehall <address@hidden> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/